@serhiyzhovnir unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Hi @dmytro-ch, thank you for the review.
ENGCOM-4512 has been created to process this Pull Request

Hi @serhiyzhovnir ! I cannot reproduce the issue on 2.3-develop instance.

Preconditions:

1. Clean Magento 2.3;
2. CRON is enable;
3. "Asynchronous sending" is enable ( Stores->Configuration->Sales->Sales Emails->General Settings ->Asynchronous sending)

Steps to reproduce:

1. Disable email sending config for Invoice, Creditmemo, Shipment entities (Stores->Configuration->Sales->Sales Emails);
2. Create Invoice, Creditmemo, Shipment via admin panel;
3. Enable email sending config for Invoice, Creditmemo, Shipment entities;
4. Wait for CRON or trigger it manually via bin/magento cron:run command

Actual Result:
The emails for the sales entities which were created with disabled email sending do not send via asynchronous email sending after enabling the email sending config for the sales entities.

Please, check again on the latest 2.3 instance.

Hi @stoleksiy
I’ve missed mention the notifications actions for order entities.

The main purpose of this pull request is to remove hardcoded values for send email field for sales entities.
After the changes of this PR the order email send value will be configured according to
On Magento 2 the issue with the order asynchronous email sending in scope of #18698 issue.

I've prepared new steps to reproduce.
We also need to trigger notify actions for Shipment, Invoice and Creditmemo entities.
These actions might be triggered by API.
In the real life these actions might be triggered by some third party integrations, for example some integration can trigger notify action when an invoice transaction is approved.

Steps To Reproduce

1. Disable email sending config for Invoice, Creditmemo, Shipment entities (Stores->Configuration->Sales->Sales Emails);
2. Create Invoice, Creditmemo, Shipment via admin panel;
3. Trigger notify actions for Shipment, Invoice and Creditmemo entities (See the instruction bellow);
4. Enable email sending config for Invoice, Creditmemo, Shipment entities;
5. Wait for CRON or trigger it manually via bin/magento cron:run command

Trigger Notify Actions

Install Postman

Install the Postman https://www.getpostman.com/.

Create Magento integration

• Create Magento Integration

• All postman requests should contain the header authorization with Access Token from Magento Integration like Bearer {Magento Access Token}

Trigger Notify Actions for Invoice

The postman request should look like on the following screenshot:

Request URL: {Magento URL}/rest/all/V1/invoices/{Invoice ID}/emails
Make sure that you use POST request and that a invoice id is right.

Trigger Notify Actions for Shipment

The postman request should look like on the following screenshot:

Request URL: {Magento URL}/rest/all/V1/shipment/{Shipment ID}/emails
Make sure that you use POST request and that a shipment id is right.

Trigger Notify Actions for Creditmemo

The postman request should look like on the following screenshot:

Request URL: {Magento URL}/rest/all/V1/creditmemo/{Creditmemo ID}/emails
Make sure that you use POST request and that a creditmemo id is right.

Thank you!

Hi @serhiyzhovnir! Thank you for the detailed description! I will check this PR again!

✔️ QA Passed

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.